[collectd] IPMI plugin discrete sensors support

[Mytnyk, VolodymyrX]

Hi All,

Currently, IPMI collectD plugin supports only analog sensors. Would it be correct to add support of discrete sensors in similar way as analogs are added? I mean to add the reading of discrete sensor values by using OpenIPMI ipmi_sensor_get_states() function and dispatch the values into collectD as a metrics? Also, discrete sensors don't provide the base unit type, which means that the type mapping can be done only based on the discrete sensor type.

Discrete sensor examples:

# ipmitool sensor get 'IPMI Watchdog'
Locating sensor record...
Sensor ID              : IPMI Watchdog (0x3)
Entity ID             : 7.1
Sensor Type (Discrete): Watchdog2
States Asserted       : Watchdog 2
                         [Timer expired]

# ipmitool sensor get 'P1 Status'
Locating sensor record...
Sensor ID              : P1 Status (0x70)
Entity ID             : 3.1
Sensor Type (Discrete): Processor
States Asserted       : Processor
                         [Presence detected]

ipmitool sensor get 'Fan Redundancy'
Locating sensor record...
Sensor ID              : Fan Redundancy (0xc)
Entity ID             : 29.1
Sensor Type (Discrete): Fan
States Asserted       : Redundancy State
                         [Fully Redundant]

# ipmitool sensor get 'PS1 Status'
Locating sensor record...
Sensor ID              : PS1 Status (0x50)
Entity ID             : 10.1
Sensor Type (Discrete): Power Supply
States Asserted       : Power Supply
                         [Presence detected]
                         [Power Supply AC lost]

# ipmitool sensor get 'Pwr Unit Redund'
Locating sensor record...
Sensor ID              : Pwr Unit Redund (0x2)
Entity ID             : 21.1
Sensor Type (Discrete): Power Unit
States Asserted       : Redundancy State
                         [Redundancy Lost]
                         [Non-Redundant: Sufficient from Redundant]

# ipmitool sensor get 'HDD 0 Status'
Locating sensor record...
Sensor ID              : HDD 0 Status (0xf0)
Entity ID             : 15.1
Sensor Type (Discrete): Drive Slot / Bay

Thanks and Regards,
Volodymyr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.verplant.org/pipermail/collectd/attachments/20161205/3a83c1b0/attachment.html>