[collectd] Feature request: hostname to log for error "csnmp_instance_list_add failed."

Sergey a_s_y at sama.ru
Fri Sep 19 11:16:41 CEST 2014


Hello.

This message is not informative:

collectd: snmp plugin: csnmp_instance_list_add failed.
collectd: snmp plugin: csnmp_instance_list_add failed.

What about to add hostname to this message ?

--- collectd-5.2.1/src/snmp.c.orig      2014-09-19 08:40:13.000000000 +0000
+++ collectd-5.2.1/src/snmp.c           2014-09-19 08:41:07.000000000 +0000
@@ -1399,7 +1399,7 @@
       if (csnmp_instance_list_add (&instance_list_head, &instance_list_tail,
            res, host, data) != 0)
       {
-        ERROR ("snmp plugin: csnmp_instance_list_add failed.");
+        ERROR ("snmp plugin: host %s: csnmp_instance_list_add failed.",host->name);
         status = -1;
         break;
       }

-- 
Regards,
Sergey



More information about the collectd mailing list