[collectd] AIX: WPAR and cpu patchs.

Florian Forster octo at collectd.org
Fri Sep 3 13:27:57 CEST 2010


Hi Manuel,

On Wed, Aug 25, 2010 at 04:07:31PM +0200, Manuel Luis Sanmartín Rozada wrote:
> cc1: warnings being treated as errors
> cpu.c: In function 'cpu_read':
> cpu.c:566: warning: unused variable 'temp'

fixed that, thanks :)

> In the wpar plugin I change some strings, and the wpar cpu code.
> The cpu part was wrong, I send an old version.
> I need to do some calculations to convert the physical tics to
> something like cpu total from 0 to 100.

I've applied the changes that fix your typos, too.

I'm having reservations regarding the mangling of the CPU counters,
though. The basic unit here *is* ticks and I think it should be left to
front-ends to convert this to a percentage if the users wishes so. Also,
submitting the raw ticks would be consistent with the CPU and LPAR
plugins.

Best regards,
—octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x0C705A15
http://octo.it/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: Digital signature
URL: <http://mailman.verplant.org/pipermail/collectd/attachments/20100903/cd718d4f/attachment.pgp>


More information about the collectd mailing list