[collectd] curl_xml plugin
amit.gupta221 at gmail.com
Mon Jan 11 07:32:29 CET 2010
On Fri, Jan 8, 2010 at 6:02 PM, Sebastian Harl <sh at tokkee.org> wrote:
> Thanks for the updated patch!
> I haven't looked at your patch yet (will do so later, unless Florians
> beats me to it ;-)), but I've got one quick comment: Other plugins that
> use a similar configuration, named their config options "InstanceFrom"
> and "ValuesFrom". For consistency, your plugin should follow that scheme
> as well. Anyway, no need to send another patch -- we can change that as
> well. I just wanted to let you know … ;-)
I am okay doing this change as well :). I would wait for the review
comments you would have for the code and then submit the updated patch with
all the changes in one go.
> Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/
> Those who would give up Essential Liberty to purchase a little Temporary
> Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> -----END PGP SIGNATURE-----
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the collectd