[collectd] curl_xml plugin

Sebastian Harl sh at tokkee.org
Fri Jan 8 13:32:48 CET 2010


Heya Amit,

On Thu, Jan 07, 2010 at 06:44:30PM +0530, Amit Gupta wrote:
> The supported configuration is as follows:
> <xpath "/path/to/node(s)">
>    InstancePrefix "test" # optional
>    Instance "path/to/textnode"  # optional if base xpath expression returns
> single result i.e one matching node
>    Values "path/to/textnode1"  "path/to/textnode2"
>    Type "magic_level"
>  </xpath>

Thanks for the updated patch!

I haven't looked at your patch yet (will do so later, unless Florians
beats me to it ;-)), but I've got one quick comment: Other plugins that
use a similar configuration, named their config options "InstanceFrom"
and "ValuesFrom". For consistency, your plugin should follow that scheme
as well. Anyway, no need to send another patch -- we can change that as
well. I just wanted to let you know … ;-)

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20100108/c2cb9caa/attachment.pgp 


More information about the collectd mailing list