<br><br><div class="gmail_quote">On Fri, Jan 8, 2010 at 6:02 PM, Sebastian Harl <span dir="ltr"><<a href="mailto:sh@tokkee.org">sh@tokkee.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Thanks for the updated patch!<br>
<br>
I haven't looked at your patch yet (will do so later, unless Florians<br>
beats me to it ;-)), but I've got one quick comment: Other plugins that<br>
use a similar configuration, named their config options "InstanceFrom"<br>
and "ValuesFrom". For consistency, your plugin should follow that scheme<br>
as well. Anyway, no need to send another patch -- we can change that as<br>
well. I just wanted to let you know … ;-)<br></blockquote><div><br>I am okay doing this change as well :). I would wait for the review comments you would have for the code and then submit the updated patch with all the changes in one go.<br>
<br>Regards<br>Amit<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="h5"><br>
Cheers,<br>
Sebastian<br>
<br>
--<br>
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ <a href="http://tokkee.org/" target="_blank">http://tokkee.org/</a><br>
<br>
Those who would give up Essential Liberty to purchase a little Temporary<br>
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin<br>
<br>
</div></div><br>-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.9 (GNU/Linux)<br>
<br>
iEYEARECAAYFAktHJfAACgkQEFEKc4UBx/w56ACfYiINxx8iOaqhHxOAW7shZOd/<br>
fPoAni6Hkp2Z6Wgcvv9sbUenFF3FHogw<br>
=CUFI<br>
-----END PGP SIGNATURE-----<br>
<br></blockquote></div><br>