[collectd] [PATCH] Interface option for network plugin

[Florian Forster]

Hi Max,

sorry I'm so slow on feedback. I've finally gotten around to take a
closer look at your patches and integrated them to my master branch. I
added checks for required functions / structs to the build system and
changed your "#if KERNEL_LINUX" defines to use the results from the
configure script.

On Sun, Mar 14, 2010 at 12:54:21PM +0100, Max Henkel wrote:
> Sorry, I haven't got your point. The forwarding from interface-0 to
> interface-1 is actually possible with this style of option setting, if
> you specify the interface each time before the corresponding Server
> and Listen statements.

Yeah, but imho that's an *implicit* way to configure the desired
behavior.

> Another point is the readability. IMHO it is easier to read (and
> understand) the "Interface" option, if it is inside a closed block.

Exactly. Specifying something like
  <Listen ...>
    ...
    Interface eth2
  </Listen>
is *explicit* – which I generally prefer.

Thanks again for your patches :)

Regards,
—octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20100405/ca11c01e/attachment.pgp