[collectd] MySQL lock statistics

Florian Forster octo at verplant.org
Thu Apr 23 11:41:52 CEST 2009


Hi :)

On Thu, Apr 23, 2009 at 10:41:11AM +0200, Rodolphe Quiedeville wrote:
> I saw you correct my patch to suppress 'magic numbers', as I
> copy/paste another part I suppose you want to supress all off them, I
> dit it in this patch. This patch correct the typo I made on my name.

yeah, we all live and learn. In my case, I learned that I never re-count
the number of characters in a string, and therefore the code with hard
coded numbers is hard to read. Thanks for your patch :)

With “strlen ("foobar")” you write what you actually *mean*, i. e. “the
length of "foobar"”, instead of a number which may or may not be
correct. I'm sure most compilers have a built-in version of ‘strlen’ and
can optimize away the actual invocation.

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090423/19183e65/attachment.pgp 


More information about the collectd mailing list