[collectd] ping plugin: SEGV

[Florian Forster]

Hi Tomasz,

On Fri, Apr 03, 2009 at 12:54:34PM +0200, Tomasz Pala wrote:
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0xb5cfdb90 (LWP 31443)]
> 0xb7c1032e in ping_receive_one (fd=<value optimized out>, ph=0x0, now=0xb5cfcfcc)
>     at liboping.c:346
> 346             ptr->recv_ttl = ip_hdr->ip_ttl;
> (gdb) 
> (gdb) bt
> #0  0xb7c1032e in ping_receive_one (fd=<value optimized out>, ph=0x0, now=0xb5cfcfcc)
>     at liboping.c:346
> #1  0xb7c106d0 in ping_send (obj=0x806f418) at liboping.c:680
> #2  0xb7c1bb00 in ping_read () at ping.c:212
> #3  0x08051910 in plugin_read_thread (args=0x0) at plugin.c:205
> #4  0xb7fc5fdf in start_thread () from /lib/libpthread.so.0

thanks for the report, I was able to reproduce and fix the issue. The
problem was introduced recently with the new TTL code: It set `ptr->ttl'
without checking if `ptr' is NULL first. In fact, there is a check just
before that line, but along these lines:

  if (ptr == NULL)
    print_error_message ();
  ptr->ttd = ...;
  return (ptr);

I'll pack a new release of liboping soon.

Thanks and regards :)
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090403/6d38fa51/attachment.pgp