[collectd] 3.10.1 - proposed patch to extend sensors plugin

Florian Forster octo at verplant.org
Tue Oct 24 19:36:14 CEST 2006

Hi Lubis :)

On Tue, Oct 24, 2006 at 07:09:35PM +0200, Lubo?? Stan??k wrote:
> the patch is ready for testing.
> I was testing it for several hours and I think the plugin works well.

From what I've seen I'd say it looks very good :) I have some remarks
- I proposed filenames like `lm_sensors-<chip>/temperature-<inst>.rrd'
  so other plugins that collect temperatures, too, can use the same RRD
  file layout, making it easier to generate graphs. Could you copy the
  RRD file layouts from `src/apple_sensors.c' (temperature and fanspeed)
  and `src/battery.c' (voltage) please? Changes to the `collection.cgi'
  should not be neccessary then.
- The manpages are generated from `.pod'-files. I don't ship these
  files, because automake would then try to re-generate the manpages
  again when building the program. This would fail if `pod2man' is not
  Do you have the changes is a non-troff format that's easier to read?
  Could you provide that? If you don't have the changes in such a
  format please don't worry about it - I'll translate it myself.

Letting the user choose the naming scheme and thus being backwards
compatible it very welcome. This way I can savely include this patch in
the next minor release :)

Thanks for all the work you've put into this :)
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20061024/7001d8bc/attachment.pgp

More information about the collectd mailing list