[collectd] [RFC 0/2] Add DDERIVE and DCOUNTER types

David Gibson david at gibson.dropbear.id.au
Sat Aug 13 13:10:22 CEST 2016


Here are some draft patches which add DDERIVE and DCOUNTER data
sources types to collectd, similar to the DDERIVE and DCOUNTER types
which are in current versions of rrdtool.

I'm pretty new to collectd, so I'm not terribly sure about this
patches so far.  I'm reasonably confident about DDERIVE, but DCOUNTER
has some complications - patch 2/2 has some comments on how this
implementation differs from the rrdtool version, which I'm not
terribly happy about.

Anyway, opinions welcome about whether this is a good idea or not, and
whether this is a reasonable start on an implementation or not.

David Gibson (2):
  Add DDERIVE type
  Add DCOUNTER type

 contrib/collectd_network.py |  8 +++++++
 src/collectd-perl.pod       |  6 ++++-
 src/csv.c                   | 16 ++++++++++++-
 src/curl.c                  | 22 ++++++++++++++++++
 src/curl_xml.c              |  9 ++++++++
 src/daemon/collectd.h       |  8 +++++++
 src/daemon/common.c         | 56 ++++++++++++++++++++++++++++++++++++++++++++-
 src/daemon/common_test.c    |  3 +++
 src/daemon/plugin.c         |  6 +++++
 src/daemon/plugin.h         |  8 +++++++
 src/daemon/types_list.c     |  4 ++++
 src/daemon/utils_cache.c    | 32 ++++++++++++++++++++++++++
 src/daemon/utils_match.c    | 48 ++++++++++++++++++++++++++++++++++++++
 src/daemon/utils_match.h    | 16 +++++++++----
 src/java.c                  | 15 ++++++++++--
 src/perl.c                  | 14 +++++++++++-
 src/python.c                |  9 +++++++-
 src/pyvalues.c              | 28 +++++++++++++++++++++++
 src/redis.c                 |  6 +++++
 src/rrdcached.c             | 15 ++++++++++--
 src/tail.c                  | 20 ++++++++++++++++
 src/target_scale.c          | 26 +++++++++++++++++++++
 src/utils_format_graphite.c |  4 ++++
 src/utils_format_json.c     | 14 ++++++++++++
 src/utils_format_json.h     |  8 +++++++
 src/utils_format_kairosdb.c | 40 ++++++++++++++++++++++++++++++++
 src/utils_format_kairosdb.h |  8 +++++++
 src/utils_rrdcreate.c       |  4 ++++
 src/write_mongodb.c         |  4 ++++
 src/write_riemann.c         | 11 +++++++++
 src/write_sensu.c           | 18 ++++++++++++++-
 src/write_tsdb.c            |  4 ++++
 32 files changed, 476 insertions(+), 14 deletions(-)

-- 
2.7.4




More information about the collectd mailing list