[collectd] Ceph plugin for collectd

Dan Ryder (daryder) daryder at cisco.com
Fri Apr 4 16:36:47 CEST 2014

Hi Marc,

I'm not familiar with libyajl. The ceph plugin I'm working with is using libjson-c (https://github.com/json-c/json-c). 

The amount of code using this library in the ceph plugin isn't huge, but it would require a fair amount of changes to use libyajl instead.

Again, I haven't used libyajl before so I issued a pull request with the current plugin - using libjson-c. 


-----Original Message-----
From: Marc Fournier [mailto:marc.fournier at camptocamp.com] 
Sent: Wednesday, April 02, 2014 2:33 AM
To: Dan Ryder (daryder)
Cc: collectd at verplant.org
Subject: Re: [collectd] Ceph plugin for collectd

Hello Dan !

Thanks for following up !

Excerpts from Dan Ryder (daryder)'s message of 2014-03-14 19:17:42 +0100:
> Hi,
> I was looking through the collectd mailer-list archives and read 
> through some discussion about a ceph plugin for collectd.
> It doesn't seem like this code ever got added to the official collectd 
> code. Is there a reason for this? I saw
> https://github.com/ceph/collectd-4.10.1 on github and used the ceph 
> plugin here to get a working version.
> I forked the main collectd code and modified the ceph plugin to fix a 
> few things.
> Is there a way I can commit these plugins to the official collectd code?

Last time ceph was mentioned on the list, the question was if using libyajl (which the curl_json plugin uses) over libjson (that the ceph plugin uses) was possible. The question remains open AFAIK. From the maintenance and packaging point of view, it's really better not to depend on different libraries providing the same features.

On the other hand, if libjson is considered better than libyajl, why not consider changing curl_json to use it ?

In both cases, the amount of code actually using libjson/libyajl doesn't seem to be huge. Do you think this is something that could be done ?

BTW, I'm going to close the current pull-request for this plugin
(https://github.com/collectd/collectd/pull/522) because it seems to have went out of control:
 26 files changed, 9018 insertions(+), 7955 deletions(-)

If you have a clean working branch with the ceph plugin in it's current state, please submit it on github so people can test it, and maybe take over the supporting lib switch if you don't.

Thanks !

More information about the collectd mailing list