[collectd] Bug#625323: collectd: ftbfs with gcc-4.6 -Werror

Florian Forster ff at octo.it
Tue Aug 16 08:59:49 CEST 2011

Hello Peter,

> On Thu, Aug 11, 2011 at 11:52:02PM +0100, peter green wrote:
>> As well as the issue mentioned in this bug report I found two other
>> issues that were preventing successfull build.

thank you very much for your patch! I've committed the vast majority of it
verbatim as <http://octo.cx/61a1fa9>.

Here's what I changed:

>> -		buffer_ptr = fgets (buffer, sizeof (buffer), global_read_fh);
>> +		fgets (buffer, sizeof (buffer), global_read_fh);

Leave the buffer_ptr in there and use it to write a warning when an
unexpected EOF is read.

Neither the current collectd-4.10 nor the collectd-5.0 branch compile
without typename_len in src/plugin.c. I've dismissed this hunk completely.

Thanks again :)

More information about the collectd mailing list