[collectd] java plugin class files

[Amit Gupta]

Today, I downloaded collectd-4.9.0 source code. However, I couldn't see the
jar patch applied as yet.  Here is the updated patch with respect to 4.9.0
source code.

Let me know if there are any issues with the patch.

Regards
Amit

On Mon, Sep 14, 2009 at 7:53 PM, Amit Gupta <amit.gupta221 at gmail.com> wrote:

> Here is the updated patch.
>
>
> On Mon, Sep 14, 2009 at 7:19 PM, Sebastian Harl <sh at tokkee.org> wrote:
>
>> Hi Amit,
>>
>> On Mon, Sep 14, 2009 at 07:02:20PM +0530, Amit Gupta wrote:
>> > Do find the patch attached. I have also got the jmx java classes to be
>> > compiled (as a part of build process) in this patch. Let me know if the
>> > patch looks okay.
>>
>> The patch looks mostly fine to me. See two small comments / nitpicks
>> below.
>>
>> > diff --git a/bindings/java/Makefile.am b/bindings/java/Makefile.am
>> > index af5e480..0d9ee74 100644
>> > --- a/bindings/java/Makefile.am
>> > +++ b/bindings/java/Makefile.am
>> […]
>> > +install-exec-local: java-build-stamp jmx-build-stamp
>> > +       mkdir -p "$(DESTDIR)$(pkgdatadir)/java"
>> > +       $(JAR) cf java-plugin.jar "org/collectd/api"/*.class
>> > +       $(JAR) cf jmx.jar "org/collectd/java"/*.class
>> > +       $(INSTALL) -m 644 java-plugin.jar \
>> > +               "$(DESTDIR)$(pkgdatadir)/java"
>> > +       $(INSTALL) -m 644 jmx.jar \
>> > +               "$(DESTDIR)$(pkgdatadir)/java"
>>
>> What do you think about creating the jar files in .libs/ or something?
>> That would avoid problems with locally modified versions …
>>
>
> ok. I now create a .libs dir right in the bindings/java during the install.
>
>>
>> >  clean-local:
>> […]
>> > +       rm -f *.jar
>>
>
> Make sense. I now delete the .libs dir containng the jars during clean.
>
> Regards
> Amit
>
>>
>> Removing all jar files in the top level java directory does not sound
>> like a good idea to me. Developers might have other jar files around for
>> testing purposes or whatever. Unconditionally removing some directory
>> .libs/ would be fine for me though.
>>
>> Hope you'll forgive my nitpickyness ;-)
>>
>
>
>>
>> Cheers,
>> Sebastian
>>
>> --
>> Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/
>>
>> Those who would give up Essential Liberty to purchase a little Temporary
>> Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin
>>
>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.9 (GNU/Linux)
>>
>> iEYEARECAAYFAkquSgMACgkQEFEKc4UBx/xqkACePMpSkHWdgzSBqpfT5qP7yAPH
>> T䀊ࠝﴃ攲࿨鳣龞ꄬ딤�
>> =rbmf
>> -----END PGP SIGNATURE-----
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.verplant.org/pipermail/collectd/attachments/20100128/1c6a8c7e/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: collectd-4.9.0-mine.patch
Type: text/x-patch
Size: 2972 bytes
Desc: not available
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20100128/1c6a8c7e/attachment-0001.bin