[collectd] Fwd: rrd_queue_thread issue

[Amit Gupta]

---------- Forwarded message ----------
From: Amit Gupta <amit.gupta221 at gmail.com>
Date: Mon, May 18, 2009 at 10:46 PM
Subject: Re: [collectd] rrd_queue_thread issue
To: Florian Forster <octo at verplant.org>


Hi Florian,

In collectd 4.7.0, there seems to be a variable queue_thread_running
to keep track of running threads. We can probably use that variable
itself to avoid rrdtool plugin to be inited again.

The patch for the same is attached. This patch may not work on 4.6.x
branch since this variable seems to be introduced only in 4.7.0.

Regards
Amit

On Mon, May 18, 2009 at 9:07 PM, Florian Forster <octo at verplant.org> wrote:
> Hi Amit,
>
> On Mon, May 18, 2009 at 08:05:38PM +0530, Amit Gupta wrote:
>> Could you share the fix with me?. I didn't notice it to be committed
>> to the collectd tree as yet.  I had applied a quick dirty patch in my
>> source tree to get rid of this problem (returning from rrd_init
>> function in the beginning itself if the number of threads aren't equal
>> to zero) .  I would prefer applying a right patch than the hack patch
>> of mine :)
>
> sure, but actually the ``real deal'' doesn't do much different:
> <http://git.verplant.org/?p=collectd.git;a=commitdiff;h=f331f9975e8d90a8c430ee7c739c4c3ed8bbb1ec>
>
> I'll merge this to the collectd-4.7 and master branches later, when I
> build the new tarballs.
>
> Regards,
> -octo
> --
> Florian octo Forster
> Hacker in training
> GnuPG: 0x91523C3D
> http://verplant.org/
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFKEYDHHdggu3Q05IYRAlk1AJ9x0iSwP7N9vkx5u0JgPC/fIK5+zQCbBMzt
> l69rx0OZDyS3Ri/FoBYFiFg=
> =A5c1
> -----END PGP SIGNATURE-----
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rrd_queue_thread_fix.patch
Type: text/x-patch
Size: 3521 bytes
Desc: not available
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090520/a352b3f8/attachment.bin