[collectd] ip6tables and uptime plugin

[Florian Forster]

Hi Marco,

thank you very much for your patch :)

On Tue, Mar 10, 2009 at 05:07:22PM +0100, Marco Chiappero wrote:
> I forked the iptables plugin and created the ip6table one. It's
> basically a 5 minute hack since IPv6 libiptc interface is consistent
> with the one dealing with IPv4, so it's just a mere renaming task.

Sorry, but I don't have an opinion on the separate vs. combined plugin
question yet. I'll take a closer look at your patch at the weekend and
let you know :)

> About the uptime plugin...
> First of all I have to say that using own plugins it's a pain because
> you need to recompile every time a newer collectd version is out or
> you want to upgrade. Thus the question is: if I write an uptime
> plugin, are you going to include it in the upstream tree?

Of course: Just because it's useless to me doesn't mean I won't accept
such a plugin.. The UUID plugin is totally useless for *my* situations,
too, but people in the cloud-computing business seem to be quite happy
about it.. In my experience, the use-cases I can imagine are only the
tip of the iceberg.

>  * collectd - src/ip6tables.c
>  * Copyright (C) 2007 Sjoerd van der Berg
[...]
>  * Authors:
>  *  Sjoerd van der Berg <harekiet at users.sourceforge.net>

Since I'm seeing this just now: Could you please add yourself as a
copyright holder and author to the header of the file? We try to be very
correct about that ;)

Oh, and please add the new plugin to the `README' file and change the
header in src/collectd.conf.pod from
 =head2 Plugin C<iptables>
to
 =head2 Plugins C<iptables> and C<ip6tables>

Best regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090311/4d094188/attachment.pgp