[collectd] Bug in utils_cache.c

Florian Forster octo at verplant.org
Wed Jul 8 10:55:11 CEST 2009

Hi Paul,

On Tue, Jul 07, 2009 at 01:16:48PM -0600, Paul Sadauskas wrote:
> tokkee on IRC & I think we found a bug with utils_cache.c. The
> uc_check_timeout function is missing a continue after the
> "uninteresting" service check, that causes a key to be null.

thanks for the patch. I think there should be a `continue' there, but
the assertion failure may have resulted from a different problem: As you
can see in the context of your patch, `ce' is freed in this case. But
it's not allocated/written to in that loop before that, so it may free
the entry of the previous iteration (without calling avl_remove). I
think *that* caused the problem.

I've applied the patch to the collectd-4.6 branch and will merge it to
collectd-4.7 and master later today.

Best regards,
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090708/9f62ca64/attachment.pgp 

More information about the collectd mailing list