[collectd] Bug#535787: collectd: powerdns monitoring hangs on the pdns socket (pdns 2.9.22)

[Sebastian Harl]

Hi Luke,

On Tue, Jul 28, 2009 at 06:00:31PM -0700, Luke Heberling wrote:
> On Tuesday 28 July 2009 02:24:15 Sebastian Harl wrote:
> > What do you think about using interval_g instead (or interval_g / 2 and
> > / or setting some maximum value)? Basically, that should not make a big
> > difference, but, imho, it's a bit cleaner to let recv() fail before the
> > end of the read interval.
> 
> sounds good. how about max( 2, interval_g * 3 / 4  )?

For now, this sounds fine to me. There are some (vague) plans to support
sub-second resolution some time in the future - in that case using a
minimum timeout of 2s might not be an optimal choice. However, currently
this should not be a problem in real life and it should be easy to adopt
in the future, so I'll use that patch for now.

> Updated the patch. Also fixed the error message to mention the LocalSocket 
> config, not the Plugin config. Compiled the package with these modifications, but 
> didn't install or run.

I'll test it before uploading the package. Thanks again for providing
the patch!

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090819/fbff2485/attachment.pgp