[collectd] Madwifi plugin v2

Ondrej Zajicek santiago at crfreenet.org
Sun Aug 16 13:47:09 CEST 2009


On Sun, Aug 16, 2009 at 09:58:47AM +0200, Florian Forster wrote:
> > This is not correct, because readlink does not terminate returned
> > string by zero. Therefore, this change adds some trash after the end
> > of the string.
> 
> Oops, you're right. I've changed this to a ???memset??? before the call to
> ???readlink???. Also, I've changed the array dimensions to ???PATH_MAX???.

...

These fixes are OK to me.

> Thanks again for your feedback. By the way, I've created a wiki page for
> the plugin [0]. It'd be great if you could proofread it.

I moved some statistics that were special just from implementation
POV and not from user POV to appropriate group. I will update the
page to contain info about config options.

-- 
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090816/a6f0c7ef/attachment.pgp 


More information about the collectd mailing list