[collectd] ip6tables plugin

[Florian Forster]

Hi Marco,

On Mon, Apr 20, 2009 at 11:36:45AM +0200, Marco Chiappero wrote:
> Here is a stub but I have some trouble in making it work with "Chain6"
> rules, maybe I don't know exactely how to deal with configuration
> keys. I get "collectd[4887]: Plugin `iptables' did not register for
> value `Chain6'". Is there something I'm forgetting?

I'll take a look. Sorting out those configuration issues shouldn't be a
problem..

> There is another issue, the naming shema. I temporally changed the
> ipv6 vl.plugin to "ip6tables" in the meantime. Options are:
> - different vl.plugin if possible (backward compatible)
> - new vl.plugin_instance name schema with ip protocol (not backward
>   compatible)
> - new vl.type "ip6t_packets" and "ip6t_bytes" (backward compatible but 
>   taints the types.db with useless data)

I'd go for the second approach: Set plugin-instance to "ipv6" when
handling ip6_tables and to "" (i. e. an empty string) when handling
ip_tables. This should be backwards compatible, though not the most
consistent way of naming. There is a wiki page [0] where we document
stuff like this which should be changes with a backwards incompatible
version 5.0 (not that we're currently planning one, but it pays to keep
track).

> A note about the code: I created two different submit_chain and
> submit_match because using void pointers (and casting them afterwards)
> in a single function it's a little bit obscure and complicated with no
> real advantage. Sorry for some code duplication but in my opinion this
> is smartest way.

Okay, I'll take a look. We have dozens of submit functions already, so I
don't think that's a big issue..

> Let me know your opinion, thank you.

Sure, thank you for the code :)

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090420/031084aa/attachment.pgp