[collectd] [PATCH] fix compile ifndef HAVE_GCRYPT_H

[Doug MacEachern]

Hi Florian,

Happy to, here are the details from that system:

% cat /etc/redhat-release 
CentOS release 4.4 (Final)

% /usr/bin/libgcrypt-config --version
1.2.0

% yum list | grep gcrypt
libgcrypt.i386                           1.2.0-3
installed
libgcrypt.x86_64                         1.2.0-3
installed
libgcrypt-devel.x86_64                   1.2.0-3
installed

% grep -n2 gcry_randomize /usr/include/gcrypt.h
1311-/* Fill BUFFER with LENGTH bytes of random, using random numbers of
1312-   quality LEVEL. */
1313:void gcry_randomize (unsigned char *buffer, size_t length,
1314-                     enum gcry_random_level level);
1315-

> -----Original Message-----
> From: Florian Forster [mailto:octo at verplant.org]
> Sent: Friday, April 17, 2009 1:31 AM
> To: Doug MacEachern
> Cc: collectd at verplant.org
> Subject: Re: [collectd] [PATCH] fix compile ifndef HAVE_GCRYPT_H
> 
> Hi Doug,
> 
> thanks for the patch, it's applied. I've tested again with `--with-
> libgcrypt=no' so all the defines and variables are in the right
place..
> 
> I've seen another problem in one of the build logs (a *big* thanks for
> this wonderful installation!):
> <http://hudson.hyperic.com/job/collectd-master-amd64-linux-
> 2.6/4/console>
> network.c: In function `networt_send_buffer_encrypted':
> network.c:2087: warning: passing arg 1 of `gcry_randomize' from
> incompatible pointer type
> network.c:2095: warning: passing arg 1 of `gcry_randomize' from
> incompatible pointer type
> 
> Could you tell me the version of libgcrypt on that machine and the
> prototype of the `gcry_randomize' function? On all my machines the
> prototype is
>   void gcry_randomize (void *buffer, size_t length,
>        enum gcry_random_level level);
> which should be fine.
> 
> I'm having the (Debian) versions `1.2.3-2' and `1.4.4-2', the (Fedora)
> version `1.2.4-6' you quoted in your mail should be right between
them.
> I'd be surprised if the gcrypt people changes the prototype and then
> changed it back..?
> 
> Regards,
> -octo
> --
> Florian octo Forster
> Hacker in training
> GnuPG: 0x91523C3D
> http://verplant.org/