[collectd] apache and collectd plugin

[Amit Gupta]

Thanks for looking into the patch. I will be working on your
suggestions and will re-submit the patch.

Regards
Amit

On Wed, Apr 15, 2009 at 2:50 PM, Florian Forster <octo at verplant.org> wrote:
> Hi Amit,
>
> On Tue, Apr 14, 2009 at 09:07:28PM +0530, Amit Gupta wrote:
>> Do find the patch attached.
>
> your patch applied cleanly to the Git master branch :)
>
> I've seen some minor issues:
>
>  - The handling of ‘lci’ in ‘config’ has some problems, I think: If
>   ‘child’ is “Instance”, its ->key, ->values etc. are copied to ‘lci’.
>   Later, in the ‘if (lci)’ block, they are overwritten. I'd simply
>   remove the support for “Instance” in the legacy code.
>  - In the ‘if (lci)’ block: lci->values is allocated but never freed.
>  - It'd be awesome if you could pull the ‘apache_buffer’ variable and
>   friends into the ‘apache_t’ structure. You can pass the
>     apache_t *st;
>   to the ‘apache_curl_callback’ function using:
>     curl_easy_setopt (st->curl, CURLOPT_WRITEDATA, st);
>   The argument ‘stream’ will then be a pointer to ‘st’. This will allow
>   to query multiple hosts in parallel, as will be the case with the
>   “complex read” stuff.
>
> I've attached an updated patch: I've removed some now unused variables,
> fixed some whitespace issues and converted the C++-style comments to
> C-style comments. I'd be great if you could base further changes on this
> patch.
>
> Regards :)
> -octo
> --
> Florian octo Forster
> Hacker in training
> GnuPG: 0x91523C3D
> http://verplant.org/
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFJ5abtHdggu3Q05IYRAq2QAJsG7YvQIFwM2ybHzZn+lPnnkeSotgCfe/JR
> s5j3gbLR+bRUwzhmo4eL3HM=
> =WqhJ
> -----END PGP SIGNATURE-----
>
>