[collectd] nut plugin - battery.runtime problem

[Marco Chiappero]

Florian Forster ha scritto:
> Hi Marco,

Hi Florian,

> On Fri, Mar 20, 2009 at 09:10:40PM +0100, Marco Chiappero wrote:
>> By the way, I would apply this patch instead, it allows further
>> readings from the MGE's UPS I own (yes, one of the two should suffice,
>> it's just a matter of reading accuracy, and name to add to types.db).
> 
> sure ;)

Calculation using power and real power should lead to better accuracy.

>> +      else if (strcmp ("output.powerfactor", key) == 0)
>> +        nut_submit (ups, "powerfactor", "output", value); /* similar type already present in types.db */
> 
> Could you throw in an appropriate type for `powerfactor'? I think it'd
> be similar to the `percent' type, right?

That's what I'm using right now :)
However the value range is 0.00 - 1.00, is it fine?
Maybe we can just collect the real power and avoid thinking about power 
factor.

>> +      else if (strcmp ("ups.realpower", key) == 0)
>> +        nut_submit (ups, "realpower", "ups", value); /* same type as "power" but different instance */
> 
> I'd probably change that to:
>   else if (strcmp ("ups.realpower", key) == 0)
>     nut_submit (ups, "power", "ups-real", value);
> 
> Does that sound reasonable?

I'd say yes.

Regards,
Marco