[collectd] Possible collectd bugs

[Florian Forster]

Hi Brian,

thanks for you bugreports :)

On Fri, Feb 22, 2008 at 06:42:25PM -0500, Brian Micek wrote:
> In collectd.c near line 95, observe:
> ERROR ("Looking up \"%s\" failed. You have set the "
				  [...]
> -                               "configuration.");
> +                               "configuration.",
> +                               hostname_g ? hostname_g : "NULL-Hostname" );

Oh, this is of course an evil bug :/ I've fixed this issue, I'll be in
the next release of 4.3. Since it's an array, not a pointer, I don't
check `hostname_g' for NULL though ;)

> In ping.c near line 111 in the function ping_init(), observe liboping
> is not initialized.  In particular, the static pointer "pingobj" which
> describes the state of the plugin is not initialized.  Please
> consider this change:

If you look close you'll see that adding a hostname to `hosts' only
succeeds if `pingobj != NULL'. However, in this case the init function
would still return zero (== success). I've changed that so it returns
(-1) (== error) instead. This will cause the plugin code in collectd to
unload the plugin and write an appropriate message to the log.

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20080223/02d6680c/attachment.pgp