[collectd] [PATCH] Make tcpconns run on OpenBSD

Florian Forster octo at verplant.org
Tue Aug 19 08:00:37 CEST 2008


Hi Michael,

On Mon, Aug 18, 2008 at 06:57:37PM +0200, Michael Stapelberg wrote:
> There are two issues with this patch:
> 1) Line 336 of the patchfile:
> +  u_long off = nl[2].n_value;
> You probably forgot to remove it, it won't be used and throws an error
> because nl isn't declared.

right, it's removed now.

> 2) -lkvm is not added to the tcpconns-linker-flags.
> After manually adding -lkvm to tcpconns_la_LDFLAGS in src/Makefile, it works.

Hm, the configure script checks for the `kvm_getswapinfo' symbol, but as
far as I can see this doesn't exist in the version of the kvm library
shipped with OpenBSD and NetBSD.. Guess we have to use yet some more
magic to find out which version we have or what system we're compiling
on.. I'll give it a shot and send you an updates patch to test, okay?

> Also, when we're at it: When specifying libstatgrab via
> --with-libstatgrab=/usr/local, it won't link with -lstatgrab. Please
> add this aswell.

Hm, could you put the file `config.log' that's produced by the configure
script on a webserver somewhere and post the link here? The library
detection/linkage is more complex than with most projects, because if we
simply use the autoconf macros as they are, all plugins and the main
daemon will be linked against all libraries, which is precisely what we
don't want..

> Besides that, it works fine ;-).

Great, thanks again for your code and help :)
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20080819/7c2a6f4d/attachment-0001.pgp 


More information about the collectd mailing list