[collectd] [PATCH] Make tcpconns run on OpenBSD

Michael Stapelberg michael at stapelberg.de
Mon Aug 18 18:57:37 CEST 2008


Hi octo,

* [18.08.08 18:02]:
> thanks for you fast reply :) I've attached a patch against the current
> master branch. Could you give it a try? I don't have any OpenBSD machine
> at hand I'm afraid :/
There are two issues with this patch:
1) Line 336 of the patchfile:
+  u_long off = nl[2].n_value;
You probably forgot to remove it, it won't be used and throws an error because
nl isn't declared.

> Okay, great, I guessed correctly ;) The patch attached will update the
> configure script (you will have to re-run `./build.sh' after applying)
> to automatically detect OpenBSD and active the tcpconns plugin when
> being built on it. The kvm lib should be detected automatically and will
> be added to the linker flags.
2) -lkvm is not added to the tcpconns-linker-flags.
After manually adding -lkvm to tcpconns_la_LDFLAGS in src/Makefile, it works.

Also, when we're at it: When specifying libstatgrab via
--with-libstatgrab=/usr/local, it won't link with -lstatgrab. Please add this
aswell.

Besides that, it works fine ;-).

Best regards,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20080818/ff6958c1/attachment.pgp 


More information about the collectd mailing list