[collectd] [PATCH] libvirtstats plugin for collectd (second version)
Richard W.M. Jones
rjones at redhat.com
Tue Nov 6 18:38:02 CET 2007
Florian Forster wrote:
> Hi Rich,
> On Tue, Nov 06, 2007 at 03:51:31PM +0000, Richard W.M. Jones wrote:
>> This patch should fix all the outstanding problems with the previous
>> version. In particular ignorelists now work fine once I fixed a stupid
>> problem in the earlier one.
> I've applied your patches to the Git repository, thank you very much for
> them :)
> If I have time and energy I'll have a look at the code tonight or
> thursday afternoon and give you some more feedback then..
> A minor thing comes to mind though: I think the name isn't optimal. It's
> optimal in the way that it'd be the only Google hit, but other than that
> people won't know what to expect from the plugin. I suggest to rename
> the plugin to `libvirt' (after the library it uses), or, since the
> library is meant to be very general, simply `vhost' or `virtualization'.
> Is there a deeper meaning in the `..stats' appendix or do you have any
> preference as to an alternative name?
I don't have any particular preference. I originally thought that I
couldn't just name the plugin 'libvirt' because then there would be two
'libvirt.so' which might cause problems.
How about 'virt' or 'virtualization' ...? I'll leave it up to you.
I have some bug fixes to follow on later.
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20071106/319ed560/attachment.bin
More information about the collectd