[collectd] [PATCH] libvirtstats plugin for collectd (second version)

Florian Forster octo at verplant.org
Tue Nov 6 18:34:01 CET 2007

Hi Rich,

On Tue, Nov 06, 2007 at 03:51:31PM +0000, Richard W.M. Jones wrote:
> This patch should fix all the outstanding problems with the previous
> version. In particular ignorelists now work fine once I fixed a stupid
> problem in the earlier one.

I've applied your patches to the Git repository, thank you very much for
them :)

If I have time and energy I'll have a look at the code tonight or
thursday afternoon and give you some more feedback then..

A minor thing comes to mind though: I think the name isn't optimal. It's
optimal in the way that it'd be the only Google hit, but other than that
people won't know what to expect from the plugin. I suggest to rename
the plugin to `libvirt' (after the library it uses), or, since the
library is meant to be very general, simply `vhost' or `virtualization'.

Is there a deeper meaning in the `..stats' appendix or do you have any
preference as to an alternative name?

Regards and thanks again :)
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 2567 bytes
Desc: not available
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20071106/44accea0/attachment.bin 

More information about the collectd mailing list