[collectd] no df statistics

[Florian Forster]

Hi Daniel,

On Fri, Feb 09, 2007 at 06:26:09PM +0000, Daniel Leite wrote:
> > Yes, I was able to reproduce the problem and fix the bug. Please try
> > the attached patch and if you could tell me `yep, works now' that's be
> > awesome :) 
> 
> yep, work now!!  :)

Okay, good. Thanks for the feedback :)

> i have a few comments about collectd in solaris, maybe its the right
> time (or already too late) to tell you...

Feedback is always welcome, especially since I hardly use Solaris
myself..

> processes.c: In function `ps_config':
> processes.c:412: warning: implicit declaration of function `ps_list_register'
> processes.c: At top level:
> processes.c:195: warning: 'list_head_g' defined but not used

I think Sebastian sent in a patch to fix a similar bug under FreeBSD and
I'm quite sure this resolves this problem, too. I'll double-check
tomorrow.

> There are more problems like this in some modules, but if i removed
> the -Werror from AM_CFLAGS in src/Makefile all compiles fine...

Could you send me the entire output of an `make all'? It _should_ build
without warnings. (In my opinion warnings are there for a reason ;)

> i also got a crash with the users plugin loaded, with truss i could
> see that it crashed openning/reading the /var/adm/utmpx

That's weird.. `collectd' uses the highlevel `getutent' or `getutxent'
functions.. I'll try to reproduce the problem tomorrow..

> i would suggest the example config to group the server config and the
> client config like this:

Sounds okay to me..

> ps: any plan to support windows

No, no serious plans at least.. As far as I know there's the `Windows
Services for UNIX' which supposedly provide the POSIX interface under
Windows. This should make it possible to compile the daemon there, I
hope. You'd still have to add some Windows-code to most of the plugins
though, so they'd be able to read some values..

Since I don't have a Windows machine, nor a Windows-license, nor an
windows-compiler it's extremely unlikely that I come around to porting
it. I'd be happy to accept patches in this direction, though.

> (or snmp) ;)

It's a bit problematic with collectd version 3, but collectd 4 will fix
these flaws. I haven't quite worked out how to best map SNMP-OIDs to
RRD-files with there DSes, min- and max-values and so on, but it'd
definitely be interesting to have such a plugin. I've come accross quite
some hardware (thermometers, RMSes, NetApps, ...) on which I cannot run
custom software but which provide some statistics via SNMP..

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20070209/552c5eff/attachment.pgp