[collectd] Generalized ignorelist functionality

Luboš Staněk lubek at users.sourceforge.net
Sat Nov 18 13:48:10 CET 2006


Hi Florian,
nice to hear that my code will be of some benefit for collectd.


Florian Forster napsal(a):
> Hi Lubos,
> 
> I've just imported your changes into the git repository. From what I've
> seen it looks very good :) I'll change the name of the file, though.
> 

No objection, it is almost your code. :)


> I'm in the process of writing an (self-balancing) binary search tree,
> which is supposed to be usable as an drop-in replacement for all the
> linked lists that are used all over the program. As far as I can tell
> it'll be a charm to use from within your code :)
> 

Well, I will wait for your changes.

I have one change in my mind.
I used the internal counter (int num;) in the configlist_t structure for
debugging purposes. It is not needed for the final build. I do not think
that it is necessary to have the information about the number of list
entries (configlist_num()) in the runtime. That is why I would move
these parts into the debug build.
I would also rename several functions like configlist_ignore =>
configlist_setignore and configlist_ignored = > configlist_isignored.


> I'll see over it more thoroughly tomorrow and maybe I have some points
> then; for now I'm hapy that is compiles cleanly :)
> 

Sure, you will. :)



Finally, one small fix in the documentation:

collectd.conf.in:
...
## There are two different naming schemes for the sensors plugin, to
preserver
## backwards compatibility. The `extended naming' is prefered, but not the
...

The last 'r' in the "preserver" is redundant. I would not also use the
comma before the infinitive.


Best regards,
Lubos



More information about the collectd mailing list