[collectd] nut plugin - battery.runtime problem

[Florian Forster]

Hi Marco,

On Fri, Mar 20, 2009 at 09:10:40PM +0100, Marco Chiappero wrote:
> By the way, I would apply this patch instead, it allows further
> readings from the MGE's UPS I own (yes, one of the two should suffice,
> it's just a matter of reading accuracy, and name to add to types.db).

sure ;)

> +      else if (strcmp ("output.powerfactor", key) == 0)
> +        nut_submit (ups, "powerfactor", "output", value); /* similar type already present in types.db */

Could you throw in an appropriate type for `powerfactor'? I think it'd
be similar to the `percent' type, right?

> +      else if (strcmp ("ups.realpower", key) == 0)
> +        nut_submit (ups, "realpower", "ups", value); /* same type as "power" but different instance */

I'd probably change that to:
  else if (strcmp ("ups.realpower", key) == 0)
    nut_submit (ups, "power", "ups-real", value);

Does that sound reasonable?

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090401/66da728d/attachment.pgp