[collectd] [PATCH 0/2] Ceph collectd plugin

Yves Mettier ymettier at free.fr
Mon Jan 21 14:00:09 CET 2013


I'm not talking about ceph (Sage will answer to that), but because some 
code was taken from my plugin, let's talk about json implemtations in 

https://github.com/collectd/collectd/pull/154 implements a jsonrpc 
plugin (if you know unixsocks, it does the same more or less with 
jsonrpc protocol).

When I developped it, I tried to do it with yajl. Then, I rewrote it 
with libjson. The bad news is that I don't remember why I *needed* to 
quit yajl. I only remember that the move from yajl to libjson was easy.

While reading my code (jsonrpc plugin), I think the 2 reasons why I 
moved to libjson are

1/ yajl is stream oriented and libjson is object oriented. I needed an 
object model and it was easier to use the libjson object model than 
reimplementing it into yajl (what I had begun to do without success).
Note : I may have missed this : 

2/ yajl has no API to create a tree and generate json from it. Or I 
have missed it.
Would this be easy to implement in yajl ?

Note : it seems there are more than one libjson. The one I'm talking 
about is https://github.com/json-c/json-c/wiki.


Le 2013-01-21 12:52, Florian Forster a écrit :
> Hi Sage :)
> thank you very much for your code!
> On Fri, Jan 18, 2013 at 05:17:17PM -0800, Sage Weil wrote:
>> There is an additional patch here to properly detect the libjson
>> dependency that comes from Yves Mettier.  Feel free to adjust the
>> changelog if you want to sign it off differently or something.
> other plugins that use JSON in one way or another use the "yajl" 
> library
> [0]. How much work would it be to refactor the code to use this 
> library
> instead?
> Best regards,
> —octo
> [0] <http://lloyd.github.com/yajl/>
> _______________________________________________
> collectd mailing list
> collectd at verplant.org
> http://mailman.verplant.org/listinfo/collectd

- Homepage       - http://ymettier.free.fr                             
- GPG key        - http://ymettier.free.fr/gpg.txt                     
- C en action    - http://ymettier.free.fr/livres/C_en_action_ed2.html 
- Guide Survie C - http://www.pearson.fr/livre/?GCOI=27440100673730    

More information about the collectd mailing list