[collectd] [PATCH 2/2] Add missing return statements, unify pthread_exit usage.
jacobsbenja at gmail.com
Tue Sep 4 09:51:05 CEST 2012
On Tue, 4 Sep 2012 09:25:21 +0200
Sebastian Harl <sh at tokkee.org> wrote:
> On Sun, Sep 02, 2012 at 11:54:35PM +0200, Benjamin Jacobs wrote:
> > - pthread_exit (NULL);
> > - return NULL;
> > + pthread_exit ((void *) 0);
> > + return ((void *) 0);
> What's the motivation for doing that (in a couple of places)?
It is to have the same pattern in every plugin. Though I confess it is
just a matter of taste (supposely NULL always = 0, right ?). Fell free
to remove those parts, but please keep the added returns wheter it is
((void*)0) or NULL. Because it fixes for me the compilation on AIX
with gcc 4.7.1. If you want, I can send you a patch with only the
addition of returns.
More information about the collectd