[collectd] Modbus segfault

[collectd at faxm0dem.org]

Hi,

On Wed, Feb 01, 2012 at 02:16:58PM +1030, Matt Baker wrote:
> Hi Stefan,
> 
> I thought I would give your modified modbus.c file a try.   It worked fine for awhile, but then it started reporting:
> 
> [2012-02-01 14:00:47] plugin_read_thread: Handling `modbus-10.1.2.2'.
> [2012-02-01 14:00:47] Modbus plugin: modbus_read_registers (10.1.2.2) failed. Giving up.
> [2012-02-01 14:00:47] Modbus plugin: modbus_read_registers (10.1.2.2) failed. Giving up.
> [2012-02-01 14:00:47] Modbus plugin: modbus_read_registers (10.1.2.2) failed. Giving up.
> [2012-02-01 14:00:47] Modbus plugin: modbus_read_registers (10.1.2.2) failed. Giving up.
> [2012-02-01 14:00:47] Modbus plugin: modbus_read_registers (10.1.2.2) failed. Giving up.
> [2012-02-01 14:00:47] Modbus plugin: modbus_read_registers (10.1.2.2) failed. Giving up.
> [2012-02-01 14:00:47] Modbus plugin: modbus_read_registers (10.1.2.2) failed. Giving up.
> [2012-02-01 14:00:47] Modbus plugin: modbus_read_registers (10.1.2.2) failed. Giving up.
> 
> 
> Looking at the code (and i'm not a C programmer), I was wondering if you thought it would be good idea if the code was changed so if it hit this sort of failure it tries to reestablish the host connection again using a mb_init_connection?

Attached patch solves this (to be applied agains stefan's fork).
Stefan: can you add it to your github, then issue a pull request?

Cheers,