[collectd] [PATCH] lpar plugin update

Aurélien Reynaud aurelien at wattapower.net
Thu Sep 9 22:43:16 CEST 2010


here is a new patch against ar/lpar with the following features :

- get back to the original implementation with gauges only. A new type
"vcpu" is created (it was "lpar_pcpu" in the original)

- I tried to keep as much as possible of your changes, but some have
been reverted (the init function is back) because it was simpler for me
to port my previous code rather than adapt it to the current form. Feel
free to change them again

- the "consumed" metric might seem superfluous at first sight as it
could be calculated in the frontend in the general case. But I thought
it might come in handy when dealing with dedicated partitions, where
donated and stolen values are no easy concepts. Not everyone wants to
dig into the code and the APIs to find out what they mean and whether
they should be added to or substracted from other values...

As a side note, one  of the changes you introduced was better checking
of the return status from perfstat_partition_total() using errno. This
reminded me that under AIX errno is by default unsafe to use in a
multithreaded environment (which collectd is). I posted a fix ("Fix
errno thread-safety under AIX") on Sat, 19 Jun 2010, which if I am not
mistaken has not been merged yet.

Best regards,

Aurélien Reynaud
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lpar.patch
Type: text/x-patch
Size: 13202 bytes
Desc: not available
URL: <http://mailman.verplant.org/pipermail/collectd/attachments/20100909/8cbdce52/attachment.bin>

More information about the collectd mailing list