[collectd] [PATCH 2/3] lpar plugin: update comment regarding poll_idle vs pool_busy

Aurélien Reynaud collectd at wattapower.net
Thu Oct 14 22:09:28 CEST 2010


From: Aurelien Reynaud <collectd at wattapower.net>


Signed-off-by: Aurelien Reynaud <collectd at wattapower.net>
---
 src/lpar.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/lpar.c b/src/lpar.c
index b9471fb..d25715e 100644
--- a/src/lpar.c
+++ b/src/lpar.c
@@ -241,9 +241,8 @@ static int lpar_read (void)
 		double pool_busy_cpus;
 
 		/* We're calculating "busy" from "idle" and the total number of
-		 * CPUs, because according to Aurélien Reynaud using the "busy"
-		 * member yields values that differ from the values produced by
-		 * the LPAR command line tools. --octo */
+		 * CPUs, because the "busy" member didn't exist in early versions
+		 * of libperfstat. It was added somewhere between AIX 5.3 ML5 and ML9. */
 		pool_idle_ns = lparstats.pool_idle_time - lparstats_old.pool_idle_time;
 		pool_idle_cpus = NS_TO_TICKS ((double) pool_idle_ns) / (double) ticks;
 		pool_busy_cpus = ((double) lparstats.phys_cpus_pool) - pool_idle_cpus;
-- 
1.7.2.2




More information about the collectd mailing list