[collectd] Varnish plugin

Marc Fournier marc.fournier at camptocamp.com
Thu Jul 1 00:28:32 CEST 2010


On Sun, Jun 27, 2010 at 08:41:19AM +0200, Jerome Renard wrote:
> Hi Marc,
> [...]
> > You'll find an implementation suggestion in this branch:
> >
> > http://github.com/mfournier/collectd/commits/varnish-data-reorg
> I have applied your patches and I had to modifiy some minor things [1].

I agree meaning is more eloquent with this change, but it breaks the
consistency where the names used to matche the names from varnishstat ...

> >
> >  - would it make more sense to name the directories after the configuration
> >   option ? ie: CollectWorkers -> varnish-instance-workers. They actually
> >   match the varnish values names (same than returned by "varnishstat -l").
> Sounds good to me.

... but in any case it's probably more comprehensive to have the
directories match the name of the configuration items. I've pushed a
trivial patch renaming a couple of values this way onto my github branch,
as we seem to agree on this.

> Data really looks better organized but I am still unsure this is the way
> to go.

Well, it's should at least be easier to make useful graphs with collection3
now :-)


More information about the collectd mailing list