[collectd] dns plugin patch

Florian Forster octo at verplant.org
Thu Feb 25 23:51:51 CET 2010

Hi Amit,

sorry for the late reply - I was out of town and am (slowly) catching up
with my emails ;)

On Mon, Feb 15, 2010 at 07:20:26PM +0530, Amit Gupta wrote:
> > > +#define SOLARIS2 10
> >
> > What does this define do? Can you document that in the code so the
> > casual reader knows what's going on?
> >
> This is needed by ip_compat.h on solaris to include the right
> structures and include files for a particular version of solaris. I am
> thinking of moving this define to the config.h.in and its value will
> be the solaris version (extracted from $host_os)

I see. Well, just some comment along the lines of "needed by Solaris in
in <ip_compat.h>" would be great then. Or just copy the above
sentences ;)

> > It's probably a good idea to base the check for
> > <netinet/ip_compat.h> on the check for <netinet/in_systm.h>.
> >
> Does including the ip_compat.h under "#if KERNEL_SOLARIS" makes sense
> given that this is a solaris specific fix?

Yeah, that would work for me, too.

Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20100225/712f65c0/attachment.pgp 

More information about the collectd mailing list