[collectd] collection3 see all selected hosts for memory and other GenericStacked

[Sebastian Harl]

Hi Peter,

On Sat, Feb 20, 2010 at 02:10:49PM +0100, Peter Holik wrote:
> Selecting more than one host for load i see a load picure for every host,
> but for example memory i see only on picture (the first host).
> 
> I fixed this by patching group_files_by_plugin_instance ths way:
> 
> --- Common.pm_orig      2010-02-20 14:04:27.000000000 +0100
> +++ Common.pm   2010-02-20 14:01:21.000000000 +0100
> @@ -106,7 +106,7 @@
>    for (my $i = 0; $i < @files; $i++)
>    {
>      my $file = $files[$i];
> -    my $key = $file->{'plugin_instance'} || '';
> +    my $key = $file->{'hostname'}.$file->{'plugin_instance'} || '';
> 
>      $data->{$key} ||= [];
>      push (@{$data->{$key}}, $file);
> 
> maybe for this purpose the name should be changed to
> group_files_by_hostname_plugin_instance

While this is a sensible thing to do given the current code / behavior,
I'd rather like to teach collection3 to display different hosts side-by-
side -- just like it was the case in collection.cgi.

What do you think about that? Would you like giving that a try?

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20100220/3b9ce07a/attachment.pgp