[collectd] [PATCH 2/2] Fixes memory leak when writing to unixsocket fails
peter at endian.com
Wed Feb 10 12:04:01 CET 2010
Florian Forster wrote:
> Hi Peter,
> On Mon, Feb 08, 2010 at 07:53:52PM +0100, Peter Warasin wrote:
>> print_to_socket() simply returns from current function always when it
>> was not able to write to the socket.
>> If this happens variables will not be freed.
> thank you very much for tracking down that memory leak.
> I'm not quite sure how I feel about the "garbage collector" yet. I'd fix
> the memory leak by simply calling "sfree" on all variables for now and
> keep the "garbage collector" as a possible new feature for the next
> version. Does that sound okay to you?
i did the garbage collector thing, because you can't know within
print_to_socket() which variables you need to sfree().
a possibility could be to turn print_to_socket() into a function and
react upon the return value, if it is -1, then sfree and return,
well, the garbage collector is also not perfect right now. it would be
better when all malloc/realloc would allocate memory to which a garbage
collector points to, instead to register the variable pointers.
needs however to change half of the code :)
right now, i also think the realloc within add_to_array() in
utils_cmd_flush changes the pointer which is registered in garbage
collector.. so that probably need some more work.
:: e n d i a n
:: open source - open minds
:: peter warasin
:: http://www.endian.com :: peter at endian.com
More information about the collectd