[collectd] [PATCH 1/2] Add collectd-flush command line utility.

Florian Forster octo at verplant.org
Fri Aug 6 13:22:53 CEST 2010


Hi Håkon,

On Thu, Aug 05, 2010 at 04:37:45PM +0200, Hakon-Dugstad.Johnsen at telenor.com wrote:
> collectd-flush is a small command-line utility which uses
> libcollectdclient to flush collectd through the unixsock plugin.

thank you for that patch :) This scratches an itch I've had for some
time, too. I never did anything about it, though, since just telnet'ing
to the appropriate port worked for me ;)

> I am no C wizard, so please bear with me if I have done something a
> stupid way. :)

Your code looks fine to me :) I've found one missing "break", but that's
it. I'm a bit concerned about using "getopt_long", since - to the best
of my knowledge - that's a GNU extension and not portable. Unless I'm
mistaken I will probably remove the long option names and go back to
"getopt".

I've applied the patches to the master branch and pushed them to my Git
repository.

Best regards,
—octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20100806/4c937c86/attachment.pgp 


More information about the collectd mailing list