[collectd] [PATCH] make rrdcached.c accept RRD creation options

Sebastian Harl sh at tokkee.org
Fri Apr 30 21:08:58 CEST 2010


Hi Thorsten,

On Fri, Apr 30, 2010 at 08:08:04AM -0700, Thorsten von Eicken wrote:
> I patched rrdcached.c to accept the same RRD creation options as the 
> rrdtool plugin accepts. It's not pretty in that it duplicates code, but 
> it works. Patch for rrdcached.c and collectd.conf.pod below.

Just a quick note, without having looked at the patch or anything ;-) It
probably makes sense to provide config handling functions in the
`utils_rrdcreate' module for parsing those options. This could then be
used in the `rrdtool' and `rrdcached' plugins. Would you be willing to
refactor the code in order to implement that?

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20100430/6e518943/attachment.pgp 


More information about the collectd mailing list