[collectd] Rare code in process.c?

[Andrés J. Díaz]

Hi Florian et al

Thanks for the reply, but we detect a minor bug in the previous patch
due to kernel 2.4


The correct patch is attached. The bug is related with kernels 2.4,
where task/ directory do not exists and
ps_read_task return -1, which is catched and raise an error (breaking
the ps_read_process function), so a NaN
is dispatched istead of values (number of process:1, number of threads :1).

Sorry for the inconvenience :(

Regards,
  Andres


2009/9/17 Florian Forster <octo at verplant.org>:
> Hi Andrés,
>
> On Thu, Sep 17, 2009 at 01:15:02PM +0200, Andrés J. Díaz wrote:
>> Mmm, why not something like: "static int ps_read_task(pid)"?
>
> looks good to me. I've applied the patch to “collectd-4.7” since it
> doesn't introduce new features. Thanks for your patch :)
>
> Regards,
> —octo
> --
> Florian octo Forster
> Hacker in training
> GnuPG: 0x91523C3D
> http://verplant.org/
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFKsmJtHdggu3Q05IYRAiKfAJ98XVhx2i1QUizzG2U7+M2EbKensgCePky3
> Cz+g6EXREg86HsIJ0oiR3OY=
> =o/tG
> -----END PGP SIGNATURE-----
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bump-ps_read_task.patch
Type: application/octet-stream
Size: 2356 bytes
Desc: not available
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090918/f60b3e2f/attachment.obj