[collectd] rrd_queue_thread issue

[Amit Gupta]

Hi Florian,

I suggested this fix because I thought we can reuse the variable which
anyway keeps track of the running threads (queue_thread_running).
Introducing a static variable is also fine.

Regards
Amit

On Wed, May 27, 2009 at 2:59 PM, Florian Forster <octo at verplant.org> wrote:
> Hi Amit,
>
> On Mon, May 18, 2009 at 10:46:54PM +0530, Amit Gupta wrote:
>> In collectd 4.7.0, there seems to be a variable queue_thread_running
>> to keep track of running threads. We can probably use that variable
>> itself to avoid rrdtool plugin to be inited again.
>
> what is the advantage of using `queue_thread_running' over using a
> static variable for this purpose? Imho the approach using the static
> variable yields code that is easier to read.
>
> Regards,
> -octo
> --
> Florian octo Forster
> Hacker in training
> GnuPG: 0x91523C3D
> http://verplant.org/
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFKHQgUHdggu3Q05IYRAhItAJ9SyGAVXTkyF8W2RpXm01SJhb7y5wCfdwU9
> O3cfL4rSR6qIGlaPt7PGgQI=
> =nFLD
> -----END PGP SIGNATURE-----
>
>