[collectd] DNS plugin to ignore numeric qtypes [fixed]

Mirko Buffoni mirko.buffoni at synthesys.it
Mon May 18 16:14:17 CEST 2009


Here is an updated patch that fix

- collectd.conf man from the correct pod file
- make use of STATIC_ARRAY_SIZE for config keys
- make use of IS_FALSE macro (no other source make use of this?)
- inverted use of keyword to SelectNumericQueryTypes defaulting to true

Here compiles flawlessy and I'm testing it right now.

Mirko

At 15:38 18/05/2009 +0200, you wrote:
>At 14:47 18/05/2009 +0200, you wrote:
> >Hi Mirko,
> >
> >thanks for your patch :)
> >
> >I have a further request: Could you change the configuration option from
> >`IgnoreNumericQueryTypes' to `SelectNumericQueryTypes'? Negated
> >configuration options lead to double-negations, such as
> >   IgnoreNumericQueryTypes false
> >which are harder to understand/read than they need to be.
>
>No problem for that.  I'm still trying to figure out how to use
>boolean macro IS_TRUE() that Sebastian suggested.
>I'll post a patch after having fixed the STATIC_ARRAY_SIZE() and
>pod files as well.
>
>Mirko
>
>
>_______________________________________________
>collectd mailing list
>collectd at verplant.org
>http://mailman.verplant.org/listinfo/collectd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: collectd-dns.patch
Type: application/octet-stream
Size: 1757 bytes
Desc: not available
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090518/342851fa/attachment.obj 
-------------- next part --------------



More information about the collectd mailing list