[collectd] [PATCH] updated ted.c based on Florian's input

Florian Forster octo at verplant.org
Sat Mar 7 11:42:21 CET 2009


Hi Eric,

thanks for your updated patch :) I'll polish the rough edges from here,
but I'll need you to test my updated code before it can go into the
repository.

I have one question though:

On Fri, Mar 06, 2009 at 09:20:18PM -0600, Eric Reed wrote:
> +        //get KiloWatts at char 247 and 248
> +        //get Voltage at char 251 and 252 
> +        *kw = ((package_buffer[248] * 256) + package_buffer[247])*10.0;
> +        DEBUG ("kw %f",*kw);

You read out kilowatts here and multiply them by ten. This would mean
that the unit used here is 10kW. This seems way to coarse for home use.
Are you sure that's *kilo*watts? Having 10W steps would make much more
sense..

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090307/99ebab45/attachment.pgp 


More information about the collectd mailing list