[collectd] [PATCH] -T option

Florian Forster octo at verplant.org
Sat Jan 17 11:14:26 CET 2009


Hi Doug,

On Fri, Jan 02, 2009 at 05:21:45PM -0500, Doug MacEachern wrote:
> The -T switch:
> - implies -f
> - does not start any read threads
> - invokes callback() foreach list_read and will exit 1 on failure, 0
> otherwise

I've just applied your changes for the -T command line argument. It
looks good, but I've sone two small changes:

 - Have the `read all once' function try *all* read-functions, even if
   one of them fails. That way you should get the information such as
   ``foo, bar, AND qux don't work'' instead of ``foo doesn't work. *next
   try* bar doesn't work. *next try* qux doesn't work. …''
 - If `read all once' returns non-zero, don't just quit but call the
   shutdown functions first. This is important if your test-setup loads
   the unixsock plugin, for example.

> The csv patch allows DataDir to be configured to "stdout" or "stderr"
> and just prints what would have been the filename (minus date stamp) =
> values.  For example:
> thresher/load/load=1230934282,0.000000,0.010000,0.000000

Not that it makes much real sense, but wouldn't it be so much cooler to
produce strings that would be accepted by the exec and unixsock plugins?
I. e. something like:
  PUTVAL thresher/load/load interval=10 1230934282:0.000000:0.010000:0.000000

That's not exactly in the CSV format anymore, but we could always add
another plugin for that ;) What do you think?

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20090117/4cfee2fe/attachment.pgp 


More information about the collectd mailing list