[collectd] [PATCH] Import changes done to collectd:bindings/java.
Doug MacEachern
dougjm at gmail.com
Sat Feb 21 19:45:05 CET 2009
On Feb 21, 2009, at 3:09 AM, Florian Forster wrote:
> From: Florian Forster <octo at leeloo.lan.home.verplant.org>
>
> Hi Doug,
>
> I've done some changes to the Java classes in collectd. Mostly I've
> moved the classes representing data types in collectd to the
> `org.collectd.api' namespace where they will be used by the upcoming
> Java plugin.
>
> I'd be glad if you could review these changes and add them to
> `jcollectd' :)
>
> The changes are:
>
> - DataSet: Added a new class to represent data sets. This class
> basically ties together a type and data sources (stored as
> List<DataSource>).
> The main reason for this new class is `parseDataSet' which is
> used in
> `TypesDB'.
> - DataSource: Implement `parseDataSource' (basically copied from
> `TypesDB').
> - TypesDB: Use `parseDataSet' to parse the `types.db' file. This
> makes
> the code much simpler and doesn't need any access to internal
> fields
> anymore.
Hi Florian,
Looks great to me, I've applied your patches, thanks! I just needed
to change the test and mx classes to use the new package name.
Thanks,
-Doug
More information about the collectd
mailing list