[collectd] Memory leaks

[Florian Forster]

Hi Niraj,

On Thu, Oct 09, 2008 at 02:20:45PM -0700, Niraj Tolia wrote:
> While on the topic, here are a couple of other leaks:

> ==30675==    by 0x40AC00: uc_update (utils_cache.c:179)

> My guess is that you don't free 'key' after the call to c_avl_remote()
> in uc_check_timeout() in utils_cache.c. Would this be correct?

uh, yes, that's a serious one, since it happens within the main loop and
within the core daemon, too :/ I've applied a fix to the 4.4 branch and
will give it some testing later today.

> ==30675== 1,934 (480 direct, 1,454 indirect) bytes in 1 blocks are definitely lost in loss record 34 of 63
> ==30675==    by 0x407497: cf_ci_append_children (configfile.c:429)

> Not 100% sure on how to fix this one as I don't understand that code
> too well.

Are you using a version with this [0] fix included? As far as I see this
*should* take care of that problem, too. I'll merge those changes into
the 4.5 and master branches later, that should simplify testing :)

Regards,
-octo

[0] <http://git.verplant.org/?p=collectd.git;a=commitdiff;h=3c316743f0dccb70e49a10ed44951dd4b289d9f0>
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20081010/834d1bf4/attachment.pgp