[collectd] Updated collection.cgi

[Florian Forster]

Hi Mirko,

thanks for your patch :)

On Sat, Nov 15, 2008 at 01:25:43PM +0100, Mirko Buffoni wrote:
> I have updated collection.cgi to be more usable (at least to me) and
> took the opportunity to update it for vmem support too.

I noticed you updated the old script, which I planned to supersede with
with the script in `contrib/collection3'. Especially adding new graphs
and ``meta-graphs'' is much easier with that..

> - Improved selection window so to be always visible.  At first I
>   thought to change the behavior, but I realized that multiselect
>   can be useful and quite general purpose, so I left it in and
>   positioned the window top-right fixed.

Sounds good :) I've already done something similar for collection3,
though I may not have checked that in yet.. Could you move the style
arguments to the global <style> block instead of using one huge
style="..." option?

> - I introduced metagraphs for vmpage_number, vmpage_action
>   I invite the author of vmem plugin to update colors to reflect
>   the correct importance.  I'm not too much into vmem pages mess.
>   I also do not have sufficient data to see if current colors are
>   bad for readability
> - I also added vmpage_io graphs.  Some tweaking may be required,
>   because my text values often go out of graph (scaling adjustment
>   perhaps?)

Great, thanks :) Unfortunately I don't have any vmem graphs right now,
so I can't really test it. If anyone dislikes the colors, let me know ;)

> - Finally, I've added a timestamp parameter to img src requests.
>   This takes care of refreshing always with fresh content, and avoiding
>   browser cache problem.

Wouldn't it be better to add an appropriate header to the response?
Something like:
  Cache-Control: no-cache

> I've worked on collection.cgi present in collectd-4.5.1 archive.  I'm
> attaching the DIFF file because I don't know if there is any limit to
> attachments for this list.

There is, the entire file would have been too big ;)

If you follow up on this, could you please use the current version in
the Git repository as your base? You can get it from here:
  <http://git.verplant.org/?p=collectd.git;a=blob_plain;h=6990fb394516526b856213cdf77c216f40ad2257;f=contrib/collection.cgi>

Thanks again and regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.verplant.org/pipermail/collectd/attachments/20081116/22953ff1/attachment.pgp